5 replies to this topic

[Gatorhardware]

Hello everyone! It has been a while for me. I have a quick question about PHP. I am working on a site that I use the echo and include "tags" a lot. I insert data from a form using _get to a php page. I put the data into a variable (eg. $data) and need to add .php to the end of it and combine it with an include. This is what I have so far but of course it does not work. Anyone have the correct way?

<? include '<? echo $data ?>.php' ?>

[Randy]

I would change the $data variable after it's been called into the page. Also, no need for the echo since you're already in PHP mode. Something like the following should work, assuming you already have the $data variable established.

CODE

<?
$data = $data . ".php";
include($data);
?>

Or if you don't want to reset $data to add the .php part you should also be able to do something like:

CODE

<?
include($data . ".php")
?>

HTH

[projectphp]

The extra <? is doing you in, as is the echo. Once you have... never remember the term for this "opened php", you can't do it again... if that makes sense

Also, echo writes to the browser window. So what you are coding says to print out whatever $data holds, as part of an include. No idea what errors this will throw, or how PHP will handle it, but it will throw a bunch!!!

[Gatorhardware]

Thank you Randy and Projectphp. That is what I needed. I knew I could count on everyone here!

[sherri]

WOAH!! Woah!!

Are you including files with names based on user submitted input?



This is a HUGE security risk.

A MUCH better idea is to do something like this:

CODE

$myincludes[0] = "blah.php";
$myincludes[1] = "blah1.php";
$myincludes[2] = "blah2.php";
$myincludes[3] = "blahblah.php";
$myincludes[4] = "abcde.php";

$choice = intval($data);

if($choice <0 || $choice > 4){
   echo("Error...");
}else{
   include($myincludes[$choice]);
}

[Gatorhardware]

WOAH!! Woah!!

Are you including files with names based on user submitted input?



This is a HUGE security risk.

A MUCH better idea is to do something like this:

CODE

$myincludes[0] = "blah.php";
$myincludes[1] = "blah1.php";
$myincludes[2] = "blah2.php";
$myincludes[3] = "blahblah.php";
$myincludes[4] = "abcde.php";

$choice = intval($data);

if($choice <0 || $choice > 4){
   echo("Error...");
}else{
   include($myincludes[$choice]);
}

Hi sherri, No this was just for loading a file in a table cell. Thank you for the example though, I think I have a use for that.